Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41527 )
Change subject: mb/ocp/deltalake: Update IIO PCIe bifurcation according to different configs
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41527/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41527/5//COMMIT_MSG@9
PS5, Line 9: getting
get
Done
https://review.coreboot.org/c/coreboot/+/41527/5//COMMIT_MSG@9
PS5, Line 9: congfig
config
Done
https://review.coreboot.org/c/coreboot/+/41527/5/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/41527/5/src/mainboard/ocp/deltalake...
PS5, Line 24: case PCIE_CONFIG_A:
where is PCIE_CONFIG_A defined? such definition is specific to YV3. […]
I defined CONFIG_A in the first case, the bifurcation settings for each configs is documented in our internal shared excel table. Yes the ipmi_get_pcie_config is a newly added OEM command for YV3.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41527
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I412336c32d093fe2bbdc7175f8e596923c77876f
Gerrit-Change-Number: 41527
Gerrit-PatchSet: 6
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 May 2020 00:48:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment