[L] Change in coreboot[master]: WIP: Add xlate_windows to mmap 32M flash - coreboot-gerrit

7 Apr 2023


      Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Zheng Bao, Martin Roth, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74260 )
Change subject: WIP: Add xlate_windows to mmap 32M flash
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/spi/spi_map_big.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173648):
https://review.coreboot.org/c/coreboot/+/74260/comment/897843ed_9aa81920 
PS2, Line 193: 	for (page_index = 0; page_index < ROM_PAGES; page_index ++) {
space prohibited before that '++' (ctx:WxB)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74260
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd2bf1390635494443cac9ee8600a4a741a78c0d
Gerrit-Change-Number: 74260
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 07 Apr 2023 06:25:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment