Change in coreboot[master]: google/trogdor: Disable TPM IRQ for CoachZ

[Julius Werner (Code Review)]

Hello Shelley Chen, Douglas Anderson,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/48681

to review the following change.

Change subject: google/trogdor: Disable TPM IRQ for CoachZ
......................................................................

google/trogdor: Disable TPM IRQ for CoachZ

On the CoachZ variant we're seeing some weird behavior with TPM
communication: occasionally the TPM seems to be receiving the wrong
bytes. Inserting delays between transactions seems to fix the problem
and some manual tests have shown that they seem to be spurious
interrupts which may cause the flow control to get out of sync, so we
think there may be some (possibly hardware) problem with the IRQ line.
More investigation is needed, but until we root cause the problem let's
disable the TPM IRQ on CoachZ to prevent boot failures.

BUG=b:172186188
TEST=Booted Lazor (I don't have a CoachZ).

Signed-off-by: Julius Werner 
Change-Id: I6f0e8e4dddcc61cb85f4951e1e63c48e223822d1
---
M src/mainboard/google/trogdor/chromeos.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/48681/1

diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c
index 989bf69..119d2dd 100644
--- a/src/mainboard/google/trogdor/chromeos.c
+++ b/src/mainboard/google/trogdor/chromeos.c
@@ -21,8 +21,10 @@
    		"EC in RW"},
    	{GPIO_AP_EC_INT.addr, ACTIVE_LOW, gpio_get(GPIO_AP_EC_INT),
    		"EC interrupt"},
+#if !CONFIG(BOARD_GOOGLE_COACHZ)
    	{GPIO_H1_AP_INT.addr, ACTIVE_LOW, gpio_get(GPIO_H1_AP_INT),
    		"TPM interrupt"},
+#endif
    	{GPIO_SD_CD_L.addr, ACTIVE_LOW, gpio_get(GPIO_SD_CD_L),
    		"SD card detect"},
    	{GPIO_AMP_ENABLE.addr, ACTIVE_HIGH, gpio_get(GPIO_AMP_ENABLE),
@@ -32,7 +34,9 @@
    lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));
 }

+#if !CONFIG(BOARD_GOOGLE_COACHZ)
 int tis_plat_irq_status(void)
 {
    return gpio_irq_status(GPIO_H1_AP_INT);
 }
+#endif

[Douglas Anderson (Code Review)]

Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48681 )

Change subject: google/trogdor: Disable TPM IRQ for CoachZ
......................................................................

Patch Set 1: Code-Review+2

Depends on https://crrev.com/c/2595480 to not crash.  ...but then it works for me.

[Julius Werner (Code Review)]

Julius Werner has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48681 )

Change subject: google/trogdor: Disable TPM IRQ for CoachZ
......................................................................

Abandoned

Problem was found, don't need this anymore.