Change in coreboot[master]: src/include/device/device.h: Use already defined 'smbios_type11'

List overview All Threads
Download

newer

older

Change in coreboot[master]: src:...

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

10 Apr 2020 10 Apr '20

6:09 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40310 )

Change subject: src/include/device/device.h: Use already defined 'smbios_type11' ......................................................................

src/include/device/device.h: Use already defined 'smbios_type11'

include <smbios.h> to use already defined 'smbios_type11'.

Change-Id: Id412a504da2fd75648636febd150356569e07935 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/device/device.h 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/40310/1

diff --git a/src/include/device/device.h b/src/include/device/device.h index 4e9c594..d25cbd0 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -5,6 +5,7 @@ #include <device/resource.h> #include <device/path.h> #include <device/pci_type.h> +#include <smbios.h> #include <types.h>

struct device; @@ -29,7 +30,6 @@

struct bus;

-struct smbios_type11; struct acpi_rsdp;

struct device_operations {

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Nico Huber (Code Review)

10 Apr 10 Apr

8:09 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40310 )

Change subject: src/include/device/device.h: Use already defined 'smbios_type11' ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40310/1/src/include/device/device.h File src/include/device/device.h:

https://review.coreboot.org/c/coreboot/+/40310/1/src/include/device/device.h... PS1, Line 143: u8 smbios_slot_type; : u8 smbios_slot_data_width; : u8 smbios_slot_length; These are actually enums from `smbios.h` and that's what the errors with the chip.h removals are about. This should be mentioned in the commit message. That we can drop `struct smbios_type11;` is just a side-effect.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id412a504da2fd75648636febd150356569e07935 Gerrit-Change-Number: 40310 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Fri, 10 Apr 2020 18:09:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

11 Apr 11 Apr

6:52 a.m.

New subject: Change in coreboot[master]: include/device/device.h: Include <smbios.h>

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40310

to look at the new patch set (#2).

Change subject: include/device/device.h: Include <smbios.h> ......................................................................

include/device/device.h: Include <smbios.h>

smbios_slot_{type,data_width,length,designation} used for smbios_type_9 needs "smbios.h" Also use already defined 'smbios_type11' in "smbios.h". This will also include <smbios.h> in "static.c" file, this we can remove indirect includes of <smbios.h> in "chip.h"

Change-Id: Id412a504da2fd75648636febd150356569e07935 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/device/device.h 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/40310/2

HAOUAS Elyes (Code Review)

6:54 a.m.

New subject: Change in coreboot[master]: include/device/device.h: Include <smbios.h>

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40310 )

Change subject: include/device/device.h: Include <smbios.h> ......................................................................

Patch Set 2:

(1 comment)

...

Patch Set 1:

(1 comment)

Thx

https://review.coreboot.org/c/coreboot/+/40310/1/src/include/device/device.h File src/include/device/device.h:

https://review.coreboot.org/c/coreboot/+/40310/1/src/include/device/device.h... PS1, Line 143: u8 smbios_slot_type; : u8 smbios_slot_data_width; : u8 smbios_slot_length;

...

These are actually enums from `smbios.h` and that's what the errors with […]

done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id412a504da2fd75648636febd150356569e07935 Gerrit-Change-Number: 40310 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Sat, 11 Apr 2020 04:54:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Patrick Georgi (Code Review)

14 Apr 14 Apr

11:58 a.m.

New subject: Change in coreboot[master]: include/device/device.h: Include <smbios.h>

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40310 )

Change subject: include/device/device.h: Include <smbios.h> ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id412a504da2fd75648636febd150356569e07935 Gerrit-Change-Number: 40310 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Tue, 14 Apr 2020 09:58:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

27 Apr 27 Apr

10:42 p.m.

New subject: Change in coreboot[master]: include/device/device.h: Include <smbios.h>

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40310 )

Change subject: include/device/device.h: Include <smbios.h> ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40310/1/src/include/device/device.h File src/include/device/device.h:

https://review.coreboot.org/c/coreboot/+/40310/1/src/include/device/device.h... PS1, Line 143: u8 smbios_slot_type; : u8 smbios_slot_data_width; : u8 smbios_slot_length;

...

done

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id412a504da2fd75648636febd150356569e07935 Gerrit-Change-Number: 40310 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Mon, 27 Apr 2020 20:42:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Patrick Georgi (Code Review)

1 May 1 May

8:15 a.m.

New subject: Change in coreboot[master]: include/device/device.h: Include <smbios.h>

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40310 )

Change subject: include/device/device.h: Include <smbios.h> ......................................................................

include/device/device.h: Include <smbios.h>

Change-Id: Id412a504da2fd75648636febd150356569e07935 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/40310 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/device.h 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/src/include/device/device.h b/src/include/device/device.h index c21067d..72df751 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -5,6 +5,7 @@ #include <device/resource.h> #include <device/path.h> #include <device/pci_type.h> +#include <smbios.h> #include <types.h>

struct device; @@ -29,7 +30,6 @@

struct bus;

-struct smbios_type11; struct acpi_rsdp;

struct device_operations {

-- To view, visit https://review.coreboot.org/c/coreboot/+/40310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id412a504da2fd75648636febd150356569e07935 Gerrit-Change-Number: 40310 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-MessageType: merged

1659

days inactive

1680

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)