Attention is currently required from: Shelley Chen, Ravi kumar, Dhavalp -, Ravi Kumar Bokka, Julius Werner. mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55595 )
Change subject: HACK coreboot: Fix build errors in romstage HACK ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
CB:55865 should fix the selfload issue in romstage
"[Dhaval] SHRM image is multi segment elf with segments going to discontinuous memory and there is reserved space in between segments so it is technically not possible to merge in to single segment elf. SHRM is required for DDR initialization and must be loaded before QcLIB DDR configuration can be handled. Hence, Multi-segment elf loading support in ROMStage is required and unavoidable. Going back to history, to handle ROMStage limitation of not supporting multi-segment elf load during first project, we had to merge all QcLib segments which was workaround. We also had to split SoC logic in rom-stage and ram-stage for images like AOP which is also multi-segment elf and impossible to merge segments due to physically discontinuous memory hence AOP was loaded in ramstage. Now SHRM image is in the same boat as AOP and have to be loaded in ROMStage. With multi-segment elf support in ROMstage for SHRM, it makes complete sense to do what originally was planned by moving AOP and other possible SoC images loading to ROM stage."
-
mturney mturney (Code Review)