Change in coreboot[master]: drivers/usb/ehci_debug.c: Drop dead code

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

8 Jul 2020 8 Jul '20

7:23 a.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43256 )

Change subject: drivers/usb/ehci_debug.c: Drop dead code ......................................................................

drivers/usb/ehci_debug.c: Drop dead code

This code is not even being build-tested. Drop it before it grows moss.

Change-Id: I27e4d66a1c8e2ed0eb5152f6bd56cc3fec2dea8e Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/usb/ehci_debug.c 1 file changed, 0 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/43256/1

diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index 739e599..28c935b 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -563,13 +563,6 @@ } dprintk(BIOS_INFO, "EHCI debug port enabled.\n");

-#if 0 - /* Completely transfer the debug device to the debug controller */ - portsc = read32(&ehci_regs->port_status[debug_port - 1]); - portsc &= ~PORT_PE; - write32(&ehci_regs->port_status[debug_port - 1], portsc); -#endif - dbgp_mdelay(100);

struct ehci_dbg_port *port = (void *)(uintptr_t)info->ehci_debug; @@ -603,8 +596,6 @@ goto try_next_time; } #else - if (0) - goto try_next_port; if (--playtimes) goto try_next_time; #endif

Attachments:

attachment.htm (text/html — 3.2 KB)

Show replies by date

Kyösti Mälkki (Code Review)

8 Jul 8 Jul

8:58 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43256 )

Change subject: drivers/usb/ehci_debug.c: Drop dead code ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43256/3/src/drivers/usb/ehci_debug.... File src/drivers/usb/ehci_debug.c:

https://review.coreboot.org/c/coreboot/+/43256/3/src/drivers/usb/ehci_debug.... PS3, Line 607: goto try_next_port; Does this still build with USBDEBUG_DEFAULT_PORT!=0 (user visible option). I think it threw errors of unused label or something like that. Should be easy to do #if/if () conversion here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27e4d66a1c8e2ed0eb5152f6bd56cc3fec2dea8e Gerrit-Change-Number: 43256 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 08 Jul 2020 11:58:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

9:05 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43256 )

Change subject: drivers/usb/ehci_debug.c: Drop dead code ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43256/3/src/drivers/usb/ehci_debug.... File src/drivers/usb/ehci_debug.c:

https://review.coreboot.org/c/coreboot/+/43256/3/src/drivers/usb/ehci_debug.... PS3, Line 607: goto try_next_port;

...

Does this still build with USBDEBUG_DEFAULT_PORT!=0 (user visible option). […]

No, it doesn't. Looks like we have an uncovered codepath

-- To view, visit https://review.coreboot.org/c/coreboot/+/43256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27e4d66a1c8e2ed0eb5152f6bd56cc3fec2dea8e Gerrit-Change-Number: 43256 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 08 Jul 2020 12:05:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

9:10 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43256

to look at the new patch set (#4).

Change subject: drivers/usb/ehci_debug.c: Drop dead code ......................................................................

drivers/usb/ehci_debug.c: Drop dead code

This code is not even being build-tested. Drop it before it grows moss.

Change-Id: I27e4d66a1c8e2ed0eb5152f6bd56cc3fec2dea8e Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/usb/ehci_debug.c 1 file changed, 0 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/43256/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/43256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27e4d66a1c8e2ed0eb5152f6bd56cc3fec2dea8e Gerrit-Change-Number: 43256 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

9:10 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43256 )

Change subject: drivers/usb/ehci_debug.c: Drop dead code ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43256/3/src/drivers/usb/ehci_debug.... File src/drivers/usb/ehci_debug.c:

https://review.coreboot.org/c/coreboot/+/43256/3/src/drivers/usb/ehci_debug.... PS3, Line 607: goto try_next_port;

...

No, it doesn't. […]

Done and CB:43295

-- To view, visit https://review.coreboot.org/c/coreboot/+/43256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27e4d66a1c8e2ed0eb5152f6bd56cc3fec2dea8e Gerrit-Change-Number: 43256 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 08 Jul 2020 12:10:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

9:38 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43256 )

Change subject: drivers/usb/ehci_debug.c: Drop dead code ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27e4d66a1c8e2ed0eb5152f6bd56cc3fec2dea8e Gerrit-Change-Number: 43256 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 08 Jul 2020 12:38:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

10 Jul 10 Jul

6:17 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43256 )

Change subject: drivers/usb/ehci_debug.c: Drop dead code ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27e4d66a1c8e2ed0eb5152f6bd56cc3fec2dea8e Gerrit-Change-Number: 43256 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Jul 2020 21:17:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

8:52 a.m.

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43256 )

Change subject: drivers/usb/ehci_debug.c: Drop dead code ......................................................................

drivers/usb/ehci_debug.c: Drop dead code

This code is not even being build-tested. Drop it before it grows moss.

Change-Id: I27e4d66a1c8e2ed0eb5152f6bd56cc3fec2dea8e Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43256 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Michael Niewöhner --- M src/drivers/usb/ehci_debug.c 1 file changed, 0 insertions(+), 7 deletions(-)

Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved

diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index 739e599..5af8e2e 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -563,13 +563,6 @@ } dprintk(BIOS_INFO, "EHCI debug port enabled.\n");

struct ehci_dbg_port *port = (void *)(uintptr_t)info->ehci_debug;

-- To view, visit https://review.coreboot.org/c/coreboot/+/43256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27e4d66a1c8e2ed0eb5152f6bd56cc3fec2dea8e Gerrit-Change-Number: 43256 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1549

days inactive

1551

days old

coreboot-gerrit@coreboot.org

7 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Kyösti Mälkki (Code Review)
Michael Niewöhner (Code Review)