Attention is currently required from: Shelley Chen, Venkat Thogaru.
Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67673 )
Change subject: soc/qualcomm/sc7280: Move AOP load and reset handle to Romstage ......................................................................
Patch Set 18:
(4 comments)
Patchset:
PS3:
Can you also mention in the commit message how much time is saved and on what devices you took measu […]
Ack
Patchset:
PS18: Able to apply changes as per the review comments suggested. Can you please review once.
File src/mainboard/google/herobrine/romstage.c:
https://review.coreboot.org/c/coreboot/+/67673/comment/a761291c_2c2bc5c1 PS3, Line 4: #include <console/console.h>
okay sure will revert these include lines
Ack
https://review.coreboot.org/c/coreboot/+/67673/comment/f25ba104_6919d9f6 PS3, Line 30: printk(BIOS_INFO, "About to call aop_fw_load_reset\n");
okay sure will revert these printk statements.
Ack