Attention is currently required from: Nico Huber, Frans Hendriks, Matt DeVillier, Arthur Heymans, Michael Niewöhner, Patrick Rudolph, Wim Vervoorn.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57262 )
Change subject: skylake DDR4 boards: Set `CaVrefConfig` to 2
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/kontron/bsl6/romstage.c:
https://review.coreboot.org/c/coreboot/+/57262/comment/c5f419cb_288a66a6
PS3, Line 40: memory_params->CaVrefConfig = 2;
Hmmm, I was much surprised to see that we didn't query Kontron about this […]
If you have schematics, it's very easy to check what the correct value is. I wrote a very long comment in CB:52110 that should explain what to look for.
With `CaVrefConfig` set to 0 on DDR4, MRC still adjusts write Vref correctly, but sometimes skips configuring CA (Command/Address) Vref for channel 1. I didn't observe any significant differences in my tests on 1DPC (DPC = DIMM Per Channel) configurations, as CA margins are pretty large. However, there could be issues with 2DPC configurations (margins aren't as good).
TL;DR: I don't expect this change to make any noticeable difference, especially on this particular board.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57262
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idab77daff311584b3e3061e9bf107c2fc1b7bdf1
Gerrit-Change-Number: 57262
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Comment-Date: Fri, 03 Sep 2021 12:27:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment