Attention is currently required from: Jonathan Zhang, Angel Pons, Arthur Heymans, Michael Niewöhner, Kyösti Mälkki, Andrey Petrov, Patrick Rudolph, Nico Huber, Anjaneya "Reddy" Chagam, Johnny Lin, Tim Wawrzynczak, Morgan Jang, Felix Held.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55114 )
Change subject: [RFC]soc/intel/common/block/pmc: Don't link get_uint_option in SMM
......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55114/comment/fb6f2638_7db39ece
PS1, Line 7: int
*u*int since CB:52672 happened
Done
https://review.coreboot.org/c/coreboot/+/55114/comment/0c53edb5_deb16f41
PS1, Line 7: src/
nit: drop `src/`
Done
https://review.coreboot.org/c/coreboot/+/55114/comment/96b98e59_02184738
PS1, Line 14: SMM handler
over 72 characters
Done
https://review.coreboot.org/c/coreboot/+/55114/comment/85cdfa6b_e9576bb3
PS1, Line 16: including
over 72 characters
Done
File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/55114/comment/1cc22d66_dba9cb9d
PS1, Line 223: const enum pmc_after_g3_power_state power_on_after_fail);
To avoid having to change each and every , I wouldn't change the signature of the `pmc_set_power_fai […]
Done
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/55114/comment/1d17ab14_94a212a0
PS1, Line 582: power_on_after_fail
How about `state` for the sake of brevity?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55114
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60986979d7f7905b312b7d03abd46ac0465ae4cf
Gerrit-Change-Number: 55114
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 02 Jun 2021 07:12:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment