Change in coreboot[master]: soc/intel/common/../car: Calculate SF Mask#1 based on MSR 0xc87
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51374 )
Change subject: soc/intel/common/../car: Calculate SF Mask#1 based on MSR 0xc87 ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51374/comment/9969e357_2289f800 PS3, Line 24: Dump CAR MSRs in bootblock.
Have you run stress test on different TGL SKUs with this change? +Raj and +Nick to keep in loop.
Ack
Commit Message:
https://review.coreboot.org/c/coreboot/+/51374/comment/f4e9c9a3_a62466c1 PS6, Line 9: MSR IA_SF_QOS_INFO (0xc87) has been introduced since TGL is used
… and is used …?
Ack
https://review.coreboot.org/c/coreboot/+/51374/comment/64baa447_71aeaeeb PS6, Line 15: Calcuate
Calculate
Ack
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/51374/comment/c2c9ae01_5dbd54c0 PS3, Line 88: IA32_SF_WAY_CNT
I got a confirmation that its being added into the SDM […]
Ack
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/51374/comment/d82964e5_8ea7955c PS5, Line 524: (1 << data_ways)
result of two below operations would be different […]
Ack
-
Subrata Banik (Code Review)