[XS] Change in coreboot[main]: mb/google/brox: Initialize TCHSCR_RST_L/EN_PP3300_TCHSCR to 0 - coreboot-gerrit

3 Feb 2024


      Attention is currently required from: Ivy Jian.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80300?usp=email )
Change subject: mb/google/brox: Initialize TCHSCR_RST_L/EN_PP3300_TCHSCR to 0
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
File src/mainboard/google/brox/variants/baseboard/brox/gpio.c:
https://review.coreboot.org/c/coreboot/+/80300/comment/e603478c_94cd5f8d :
PS1, Line 265: 	PAD_CFG_GPO(GPP_F17, 0, DEEP),
...
If we have declared "generic.detect" = "1" in devicetree. […]
Thank you very much for your help Ivy!  This was exactly the information that we were looking for.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/80300?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5bf1901a3a40a38237b950abcb758f96aebcc1cf
Gerrit-Change-Number: 80300
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sat, 03 Feb 2024 01:37:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-MessageType: comment