Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Paul Menzel, Balaji Manigandan, Bernardo Perez Priego, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58202 )
Change subject: mb/intel/adlrvp: Use dedicated VBT files for ADL-M
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/intel/adlrvp/mainboard.c:
https://review.coreboot.org/c/coreboot/+/58202/comment/cb9c003d_ef880b9e
PS3, Line 79: case ADL_M_LP5:
: return "vbt_adlrvp_m_lp5.bin";
nit: if you could move this at line 84 to club ADL-M board
Also, in future we can consider adding scalable (as below) structures rather switch cases for multiple level code. This way, we can grow the different SKUs easily.
struct vbt_config {
uint8_t sku_id;
char *file_name;
} config[] = {
{ ADL_P_LP5_1, "vbt_adlrvp_lp5.bin" },
....
};
uint8_t sku_id = get_board_id();
for (int i = 0; i < ARRAY_SIZE(config); i++)
if (config[i].sku_id == sku_id)
return config[i].file_name;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58202
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbf3f11c9277f5dcb3e12f9020f54ec843444c3f
Gerrit-Change-Number: 58202
Gerrit-PatchSet: 3
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
patrick@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Wed, 17 Nov 2021 17:27:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment