Attention is currently required from: Jeff Daly, Raul Rangel, Jonathan Zhang, Matt DeVillier, Arthur Heymans, Lance Zhao, Jason Glenesk, Tarun Tuli, Sean Rhodes, Subrata Banik, Johnny Lin, Christian Walter, Tim Wawrzynczak, Kapil Porwal, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Fred Reitberger, Felix Held, Tim Chu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74913 )
Change subject: ACPI: Add helper fill_fadt_extended_pm_io()
......................................................................
Patch Set 1:
(1 comment)
File src/acpi/fadt_filler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175356):
https://review.coreboot.org/c/coreboot/+/74913/comment/aaa00c97_0d047fba
PS1, Line 22: #define fadt_sanity(x) if (!(x)) { do_sanity_error(__func__, __LINE__); }
Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74913
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90925fce35458cf5480bfefc7cdddebd41b42058
Gerrit-Change-Number: 74913
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 02 May 2023 07:00:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment