Change in coreboot[master]: soc/intel/common/acpi: Remove gpio community range

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Aamir Bohra (Code Review)

18 May 2020 18 May '20

9:25 a.m.

Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41500 )

Change subject: soc/intel/common/acpi: Remove gpio community range ......................................................................

soc/intel/common/acpi: Remove gpio community range

Remove hardcoded gpio community range, since it might differ across the SOCs.

Change-Id: I79c10669f6096537d466d1abd356d58a50fcb8f5 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/common/acpi/gpio.asl 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/41500/1

diff --git a/src/soc/intel/common/acpi/gpio.asl b/src/soc/intel/common/acpi/gpio.asl index cac3449..dbfa7af 100644 --- a/src/soc/intel/common/acpi/gpio.asl +++ b/src/soc/intel/common/acpi/gpio.asl @@ -3,7 +3,7 @@ /* * Configure GPIO Power Management bits * - * Arg0: GPIO community (0-5) + * Arg0: GPIO community index * Arg1: PM bits in MISCCFG */ Method (CGPM, 2, Serialized)

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Tim Wawrzynczak (Code Review)

18 May 18 May

5:23 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41500 )

Change subject: soc/intel/common/acpi: Remove gpio community range ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79c10669f6096537d466d1abd356d58a50fcb8f5 Gerrit-Change-Number: 41500 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 18 May 2020 17:23:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

6:06 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41500 )

Change subject: soc/intel/common/acpi: Remove gpio community range ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79c10669f6096537d466d1abd356d58a50fcb8f5 Gerrit-Change-Number: 41500 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 18 May 2020 18:06:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

20 May 20 May

9:11 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41500 )

Change subject: soc/intel/common/acpi: Remove gpio community range ......................................................................

soc/intel/common/acpi: Remove gpio community range

Remove hardcoded gpio community range, since it might differ across the SOCs.

Change-Id: I79c10669f6096537d466d1abd356d58a50fcb8f5 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41500 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/soc/intel/common/acpi/gpio.asl 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/41500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79c10669f6096537d466d1abd356d58a50fcb8f5 Gerrit-Change-Number: 41500 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

9:33 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41500 )

Change subject: soc/intel/common/acpi: Remove gpio community range ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3630 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3629 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3628 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3627

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/41500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79c10669f6096537d466d1abd356d58a50fcb8f5 Gerrit-Change-Number: 41500 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Wed, 20 May 2020 09:33:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

24 May 24 May

8:11 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41500 )

Change subject: soc/intel/common/acpi: Remove gpio community range ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41500/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41500/2//COMMIT_MSG@10 PS2, Line 10: the SOCs. Next time it would be nice to mention that this was just updating a comment.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79c10669f6096537d466d1abd356d58a50fcb8f5 Gerrit-Change-Number: 41500 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 24 May 2020 08:11:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1589

days inactive

1595

days old

coreboot-gerrit@coreboot.org

5 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Aamir Bohra (Code Review)
Karthik Ramasubramanian (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Tim Wawrzynczak (Code Review)