Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41500 )
Change subject: soc/intel/common/acpi: Remove gpio community range ......................................................................
soc/intel/common/acpi: Remove gpio community range
Remove hardcoded gpio community range, since it might differ across the SOCs.
Change-Id: I79c10669f6096537d466d1abd356d58a50fcb8f5 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/common/acpi/gpio.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/41500/1
diff --git a/src/soc/intel/common/acpi/gpio.asl b/src/soc/intel/common/acpi/gpio.asl index cac3449..dbfa7af 100644 --- a/src/soc/intel/common/acpi/gpio.asl +++ b/src/soc/intel/common/acpi/gpio.asl @@ -3,7 +3,7 @@ /* * Configure GPIO Power Management bits * - * Arg0: GPIO community (0-5) + * Arg0: GPIO community index * Arg1: PM bits in MISCCFG */ Method (CGPM, 2, Serialized)
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41500 )
Change subject: soc/intel/common/acpi: Remove gpio community range ......................................................................
Patch Set 1: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41500 )
Change subject: soc/intel/common/acpi: Remove gpio community range ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41500 )
Change subject: soc/intel/common/acpi: Remove gpio community range ......................................................................
soc/intel/common/acpi: Remove gpio community range
Remove hardcoded gpio community range, since it might differ across the SOCs.
Change-Id: I79c10669f6096537d466d1abd356d58a50fcb8f5 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41500 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/soc/intel/common/acpi/gpio.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/common/acpi/gpio.asl b/src/soc/intel/common/acpi/gpio.asl index cac3449..dbfa7af 100644 --- a/src/soc/intel/common/acpi/gpio.asl +++ b/src/soc/intel/common/acpi/gpio.asl @@ -3,7 +3,7 @@ /* * Configure GPIO Power Management bits * - * Arg0: GPIO community (0-5) + * Arg0: GPIO community index * Arg1: PM bits in MISCCFG */ Method (CGPM, 2, Serialized)
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41500 )
Change subject: soc/intel/common/acpi: Remove gpio community range ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3630 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3629 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3628 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3627
Please note: This test is under development and might not be accurate at all!
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41500 )
Change subject: soc/intel/common/acpi: Remove gpio community range ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41500/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41500/2//COMMIT_MSG@10 PS2, Line 10: the SOCs. Next time it would be nice to mention that this was just updating a comment.
-
9elements QA (Code Review) -
Aamir Bohra (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)