Attention is currently required from: Elyes Haouas, Felix Singer, Frans Hendriks, Jérémy Compostella, Shuo Liu, Vasiliy Khoruzhick.
yuchi.chen@intel.com has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83322?usp=email )
Change subject: mainboard/intel/frost_creek: Add a new CRB Frost Creek for Snow Ridge ......................................................................
Patch Set 53:
(4 comments)
File src/mainboard/intel/frost_creek/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/83322/comment/37c2aa7a_3e0ecff8?usp... : PS19, Line 3: Scope (_SB)
where is this included?
This file is not used and I removed it.
https://review.coreboot.org/c/coreboot/+/83322/comment/28f8ad43_5aeaecde?usp... : PS19, Line 10: Name(_PRW, Package(){0x1d, 0x05})
S3 is supported?
This file has been removed.
File src/mainboard/intel/frost_creek/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/83322/comment/1dc950f9_fb5992dd?usp... : PS19, Line 3: // IO-Trap at 0x800. This is the ACPI->SMI communication interface.
the scope is \SB?
The object and method defined in this file is not referenced any where in the whole ASL source file, so it could be removed.
File src/mainboard/intel/frost_creek/romstage.c:
https://review.coreboot.org/c/coreboot/+/83322/comment/50b48565_fe3a371b?usp... : PS44, Line 12: void mainboard_config_gpios(void)
I renamed `gpio.inc` to `gpio.c` and move this function into it.
Done