Attention is currently required from: Nico Huber, Patrick Georgi, Julius Werner, Kyösti Mälkki.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61306 )
Change subject: console: Add loglevel prefix to interactive consoles
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
File src/console/printk.c:
https://review.coreboot.org/c/coreboot/+/61306/comment/6f2f1e21_22d0be30
PS5, Line 80: console_interactive_tx_byte
Yeah... […]
Yeah, we spend a ton of time just waiting for the UART controller to write a byte, so I don't think a couple function calls will really make a difference. I think it looks pretty clean now.
https://review.coreboot.org/c/coreboot/+/61306/comment/012e579a_731b64b9
PS5, Line 85:
This was my personal preference choice after playing around with various distances... […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61306
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic83413475400821f8097ef1819a293ee8926bb0b
Gerrit-Change-Number: 61306
Gerrit-PatchSet: 6
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 04 Feb 2022 17:21:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment