Change in coreboot[master]: nb/i945; Remove unused 'barrier()' function

List overview All Threads
Download

newer

older

Change in coreboot[master]: [WIP]...

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

18 Oct 2019 18 Oct '19

6:43 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36124 )

Change subject: nb/i945; Remove unused 'barrier()' function ......................................................................

nb/i945; Remove unused 'barrier()' function

Change-Id: I0c33a1f3f9c33c15a901fe90258ed989e9641701 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/i945.h 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/36124/1

diff --git a/src/northbridge/intel/i945/i945.h b/src/northbridge/intel/i945/i945.h index 69a6413..4dd5379 100644 --- a/src/northbridge/intel/i945/i945.h +++ b/src/northbridge/intel/i945/i945.h @@ -361,8 +361,6 @@

#define DMIDRCCFG 0xeb4 /* 32bit */

-static inline void barrier(void) { asm("" ::: "memory"); } - int i945_silicon_revision(void); void i945_early_initialization(void); void i945_late_initialization(int s3resume);

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

HAOUAS Elyes (Code Review)

18 Oct 18 Oct

8:28 a.m.

New subject: Change in coreboot[master]: nb/i945: Remove unused 'barrier()' function

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36124

to look at the new patch set (#2).

Change subject: nb/i945: Remove unused 'barrier()' function ......................................................................

nb/i945: Remove unused 'barrier()' function

Change-Id: I0c33a1f3f9c33c15a901fe90258ed989e9641701 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/i945.h 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/36124/2

HAOUAS Elyes (Code Review)

30 Oct 30 Oct

7:35 p.m.

New subject: Change in coreboot[master]: nb/{fsp_rangeley,haswell,i945,nehalem}: Remove unused 'barrier()'

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36124

to look at the new patch set (#3).

Change subject: nb/{fsp_rangeley,haswell,i945,nehalem}: Remove unused 'barrier()' ......................................................................

nb/{fsp_rangeley,haswell,i945,nehalem}: Remove unused 'barrier()'

Change-Id: I0c33a1f3f9c33c15a901fe90258ed989e9641701 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/fsp_rangeley/northbridge.h M src/northbridge/intel/haswell/haswell.h M src/northbridge/intel/i945/i945.h M src/northbridge/intel/nehalem/nehalem.h 4 files changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/36124/3

HAOUAS Elyes (Code Review)

7:42 p.m.

New subject: Change in coreboot[master]: {fsp_rangeley,haswell,i945,nehalem,sandybridge}: Remove unused 'barri...

Hello Patrick Rudolph, build bot (Jenkins), David Guckian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36124

to look at the new patch set (#4).

Change subject: {fsp_rangeley,haswell,i945,nehalem,sandybridge}: Remove unused 'barrier()' ......................................................................

{fsp_rangeley,haswell,i945,nehalem,sandybridge}: Remove unused 'barrier()'

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/36124/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/36124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c33a1f3f9c33c15a901fe90258ed989e9641701 Gerrit-Change-Number: 36124 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: David Guckian david.guckian@intel.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

David Guckian (Code Review)

31 Oct 31 Oct

7:58 a.m.

New subject: Change in coreboot[master]: {fsp_rangeley,haswell,i945,nehalem,sandybridge}: Remove unused 'barri...

David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36124 )

Change subject: {fsp_rangeley,haswell,i945,nehalem,sandybridge}: Remove unused 'barrier()' ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/36124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c33a1f3f9c33c15a901fe90258ed989e9641701 Gerrit-Change-Number: 36124 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian david.guckian@intel.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 31 Oct 2019 07:58:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1 Nov 1 Nov

7:41 a.m.

New subject: Change in coreboot[master]: nb/intel: Remove unused 'barrier()'

Hello Patrick Rudolph, David Guckian, build bot (Jenkins), David Guckian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36124

to look at the new patch set (#5).

Change subject: nb/intel: Remove unused 'barrier()' ......................................................................

nb/intel: Remove unused 'barrier()'

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/36124/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/36124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c33a1f3f9c33c15a901fe90258ed989e9641701 Gerrit-Change-Number: 36124 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian david.guckian@intel.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

11:34 a.m.

New subject: Change in coreboot[master]: nb/intel: Remove unused 'barrier()'

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36124 )

Change subject: nb/intel: Remove unused 'barrier()' ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c33a1f3f9c33c15a901fe90258ed989e9641701 Gerrit-Change-Number: 36124 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian david.guckian@intel.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Nov 2019 11:34:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

11:35 a.m.

New subject: Change in coreboot[master]: nb/intel: Remove unused 'barrier()'

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36124 )

Change subject: nb/intel: Remove unused 'barrier()' ......................................................................

nb/intel: Remove unused 'barrier()'

Change-Id: I0c33a1f3f9c33c15a901fe90258ed989e9641701 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36124 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/northbridge/intel/fsp_rangeley/northbridge.h M src/northbridge/intel/haswell/haswell.h M src/northbridge/intel/i945/i945.h M src/northbridge/intel/nehalem/nehalem.h M src/northbridge/intel/sandybridge/sandybridge.h 5 files changed, 0 insertions(+), 6 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/src/northbridge/intel/fsp_rangeley/northbridge.h b/src/northbridge/intel/fsp_rangeley/northbridge.h index 8375fbf..fd5fa05 100644 --- a/src/northbridge/intel/fsp_rangeley/northbridge.h +++ b/src/northbridge/intel/fsp_rangeley/northbridge.h @@ -52,7 +52,6 @@ #define P_UNIT 4

#ifndef __ASSEMBLER__ -static inline void barrier(void) { asm("" ::: "memory"); }

#define PCI_DEVICE_ID_RG_MIN 0x1F00 #define PCI_DEVICE_ID_RG_MAX 0x1F0F diff --git a/src/northbridge/intel/haswell/haswell.h b/src/northbridge/intel/haswell/haswell.h index bd89609..fce9416 100644 --- a/src/northbridge/intel/haswell/haswell.h +++ b/src/northbridge/intel/haswell/haswell.h @@ -202,7 +202,6 @@ #define DMIDRCCFG 0xeb4 /* 32bit */

#ifndef __ASSEMBLER__ -static inline void barrier(void) { asm("" ::: "memory"); }

void intel_northbridge_haswell_finalize_smm(void);

#define DMIDRCCFG 0xeb4 /* 32bit */

-static inline void barrier(void) { asm("" ::: "memory"); } - int i945_silicon_revision(void); void i945_early_initialization(void); void i945_late_initialization(int s3resume); diff --git a/src/northbridge/intel/nehalem/nehalem.h b/src/northbridge/intel/nehalem/nehalem.h index bff5595..ebec63d 100644 --- a/src/northbridge/intel/nehalem/nehalem.h +++ b/src/northbridge/intel/nehalem/nehalem.h @@ -245,7 +245,6 @@ #define DMIDRCCFG 0xeb4 /* 32bit */

#ifndef __ASSEMBLER__ -static inline void barrier(void) { asm("" ::: "memory"); }

#define PCI_DEVICE_ID_SB 0x0104 #define PCI_DEVICE_ID_IB 0x0154 diff --git a/src/northbridge/intel/sandybridge/sandybridge.h b/src/northbridge/intel/sandybridge/sandybridge.h index d505728..8664c5d 100644 --- a/src/northbridge/intel/sandybridge/sandybridge.h +++ b/src/northbridge/intel/sandybridge/sandybridge.h @@ -202,7 +202,6 @@ #define DMIDRCCFG 0xeb4 /* 32bit */

#ifndef __ASSEMBLER__ -static inline void barrier(void) { asm("" ::: "memory"); }

#ifdef __SMM__ void intel_sandybridge_finalize_smm(void);

-- To view, visit https://review.coreboot.org/c/coreboot/+/36124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c33a1f3f9c33c15a901fe90258ed989e9641701 Gerrit-Change-Number: 36124 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian david.guckian@intel.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1882

days inactive

1896

days old

coreboot-gerrit@coreboot.org

7 comments

3 participants

tags (0)

participants (3)

David Guckian (Code Review)
HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)