Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Eric Lai.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74379 )
Change subject: mb/google/rex: Add devtree update support for variants
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/rex/mainboard.c:
https://review.coreboot.org/c/coreboot/+/74379/comment/51b95e0c_67ad3e8f
PS2, Line 36: variant_devtree_update
Based on above comment, moving required things under baseboard rex to avoid repeat of code.
Done
File src/mainboard/google/rex/variants/rex0/ramstage.c:
https://review.coreboot.org/c/coreboot/+/74379/comment/521b03a6_211800ed
PS2, Line 17: }
I feel this above way of filling information is only applicable if we are sure that rex0 board won […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74379
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7953ce8dc0a247d440154902cef1007eb9358dc1
Gerrit-Change-Number: 74379
Gerrit-PatchSet: 4
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 03 May 2023 11:43:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment