Change in ...coreboot[master]: soc/intel/common/block/cpu: Use core apic id to get cpu_index()
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26346 )
Change subject: soc/intel/common/block/cpu: Use core apic id to get cpu_index() ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/26346/10/src/soc/intel/common/block/cpu/cpul... File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/#/c/26346/10/src/soc/intel/common/block/cpu/cpul... PS10, Line 327: unsigned long cpu_index(void) will this function work for all x86 that exist? I believe it will. Why have two when we can have one? It seems this is good enough but I'm not comfortable with the continued use of weak functions in our code base. It makes it impossible to know, when scanning source, what is getting compiled in. We are using weak in 326 places now so I guess there's not much choice at this point.
-
ron minnich (Code Review)