Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29361 )
Change subject: mb/google/poppy/variant/nocturne: adjust RcompTarget to fix DRAM corruption ......................................................................
mb/google/poppy/variant/nocturne: adjust RcompTarget to fix DRAM corruption
BUG=b:111812662 TEST=flash to nocturne, boot nocturne, run "memtester 1g" and verify it passes.
Change-Id: Iefc3957f915a39a47ad6018459e65b70d1b34091 Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/29361 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/mainboard/google/poppy/variants/nocturne/memory.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Nick Vaccaro: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/poppy/variants/nocturne/memory.c b/src/mainboard/google/poppy/variants/nocturne/memory.c index 0b34e72..b6c77a3 100644 --- a/src/mainboard/google/poppy/variants/nocturne/memory.c +++ b/src/mainboard/google/poppy/variants/nocturne/memory.c @@ -33,7 +33,7 @@ static const u16 rcomp_resistor[] = { 200, 81, 162 };
/* Rcomp target */ -static const u16 rcomp_target[] = { 100, 40, 40, 23, 40 }; +static const u16 rcomp_target[] = { 100, 30, 40, 23, 40 };
void variant_memory_params(struct memory_params *p) {