[XS] Change in coreboot[main]: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume

[Bill XIE (Code Review)]

Attention is currently required from: Jonathon Hall, Kyösti Mälkki, Nico Huber, Paul Menzel.

Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78288?usp=email )

Change subject: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume
......................................................................

Patch Set 6:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/78288/comment/4182a44f_637f68f5 :
PS5, Line 17: "untrained" result restored, so s3 resume will fail.
> With this commit, normal boot path will clear both bank 0 and bank 1 on cmos_error(). To me this sound like the correct think to do, but it is not mentioned in the commit message.

It is mentioned now.

https://review.coreboot.org/c/coreboot/+/78288/comment/762b5a0f_7ecdfdc5 :
PS5, Line 20: cmos_need_reset will be negated when acpi_is_wakeup_s3() returns true.
> I can give this a try and propose a patch if it works, but I won't be able to get to it today.  The S3 resume change here still makes sense to me either way.

Then, could we unblock this commit from merge?

Commit Message:

https://review.coreboot.org/c/coreboot/+/78288/comment/9963097e_7ed69f96 :
PS6, Line 16: which now clears
            : both bank 0 and bank 1
Now it is mentioned.