Change in coreboot[master]: editorconfig: add max. line length

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: [TEST]...

Michael Niewöhner (Code Review)

15 Sep 2019 15 Sep '19

3:42 p.m.

Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35412 )

Change subject: editorconfig: add max. line length ......................................................................

editorconfig: add max. line length

Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 --- M .editorconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/35412/1

diff --git a/.editorconfig b/.editorconfig index eb44fcd..b9d4fc4 100644 --- a/.editorconfig +++ b/.editorconfig @@ -9,3 +9,4 @@ insert_final_newline = true end_of_line = lf trim_trailing_whitespace = true +max_line_length = 73

Attachments:

attachment.htm (text/html — 1.9 KB)

Show replies by date

Patrick Georgi (Code Review)

15 Sep 15 Sep

10:30 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35412 )

Change subject: editorconfig: add max. line length ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35412/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35412/1//COMMIT_MSG@9 PS1, Line 9: Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 missing signed-off-by line

https://review.coreboot.org/c/coreboot/+/35412/1/.editorconfig File .editorconfig:

https://review.coreboot.org/c/coreboot/+/35412/1/.editorconfig@12 PS1, Line 12: 73 we're at 96

-- To view, visit https://review.coreboot.org/c/coreboot/+/35412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 Gerrit-Change-Number: 35412 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Sun, 15 Sep 2019 20:30:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

10:38 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35412

to look at the new patch set (#2).

Change subject: editorconfig: add max. line length ......................................................................

editorconfig: add max. line length

Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M .editorconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/35412/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 Gerrit-Change-Number: 35412 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

10:39 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35412 )

Change subject: editorconfig: add max. line length ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35412/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35412/1//COMMIT_MSG@9 PS1, Line 9: Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525

...

missing signed-off-by line

Done

https://review.coreboot.org/c/coreboot/+/35412/1/.editorconfig File .editorconfig:

https://review.coreboot.org/c/coreboot/+/35412/1/.editorconfig@12 PS1, Line 12: 73

...

we're at 96

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 Gerrit-Change-Number: 35412 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Sun, 15 Sep 2019 20:39:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:58 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35412 )

Change subject: editorconfig: add max. line length ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 Gerrit-Change-Number: 35412 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 15 Sep 2019 20:58:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

16 Sep 16 Sep

7:42 a.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35412 )

Change subject: editorconfig: add max. line length ......................................................................

Patch Set 2: Code-Review-2

(1 comment)

I strongly disagree with adding this. If it were a ruler, i'd totally support it, but it's forced wrapping, which I don't think is something we want, even at 96 characters.

This would wrap URLs in the .MD files, for example. It's just not elegant, and I don't think it was thought through.

If you want to add a max_line_length to the file, I'd set it to off.

https://review.coreboot.org/c/coreboot/+/35412/2/.editorconfig File .editorconfig:

https://review.coreboot.org/c/coreboot/+/35412/2/.editorconfig@12 PS2, Line 12: max_line_length = 96 This FORCES the maximum length (for editors that support it), which is why I didn't add it.

See this discussion: https://github.com/editorconfig/editorconfig/issues/387

-- To view, visit https://review.coreboot.org/c/coreboot/+/35412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 Gerrit-Change-Number: 35412 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 16 Sep 2019 05:42:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7:59 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35412 )

Change subject: editorconfig: add max. line length ......................................................................

Patch Set 2: -Code-Review

wow, good point. I guess the plugin for my editor isn't fully conformant then ;-)

-- To view, visit https://review.coreboot.org/c/coreboot/+/35412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 Gerrit-Change-Number: 35412 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 16 Sep 2019 05:59:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

11:56 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35412 )

Change subject: editorconfig: add max. line length ......................................................................

Patch Set 2:

...

Patch Set 2: -Code-Review

wow, good point. I guess the plugin for my editor isn't fully conformant then ;-)

Mine too. I use Atom with the editorconfig plugin, where this is just a ruler, not a hard limit

-- To view, visit https://review.coreboot.org/c/coreboot/+/35412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 Gerrit-Change-Number: 35412 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 16 Sep 2019 09:56:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

17 Sep 17 Sep

8:31 a.m.

Michael Niewöhner has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35412 )

Change subject: editorconfig: add max. line length ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/35412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 Gerrit-Change-Number: 35412 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

1894

days inactive

1896

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

Martin Roth (Code Review)
Michael Niewöhner (Code Review)
Patrick Georgi (Code Review)