I strongly disagree with adding this.
If it were a ruler, i'd totally support it, but it's forced wrapping, which I don't think is something we want, even at 96 characters.

This would wrap URLs in the .MD files, for example. It's just not elegant, and I don't think it was thought through.

If you want to add a max_line_length to the file, I'd set it to off.

Patch set 2:Code-Review -2

View Change

1 comment:

To view, visit change 35412. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525
Gerrit-Change-Number: 35412
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 16 Sep 2019 05:42:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment