Attention is currently required from: Hung-Te Lin, Xuxin Xiong, Yang Wu, Yidi Lin, Yu-Ping Wu.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81752?usp=email )
Change subject: mb/google/corsola: Set orientation to LB_FB_ORIENTATION_RIGHT_UP
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81752/comment/10054f34_db1ed96a :
PS2, Line 13: TEST=emerge-staryu coreboot chromeos-bootimage
Did you have functional test instead of just compile?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81752?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb
Gerrit-Change-Number: 81752
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 08 Apr 2024 07:16:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment