Attention is currently required from: Bora Guvendik, Anil Kumar K, Jeremy Compostella.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63945 )
Change subject: mb/intel/adlrvp: x4 slot support (SD card support) for Adl-P RVP
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/intel/adlrvp/gpio.c:
https://review.coreboot.org/c/coreboot/+/63945/comment/d14314cf_dd304efd
PS6, Line 189: // PAD_CFG_NF(GPP_A7, NONE, DEEP, NF1),
you should remove this line altogether if unnecessary instead of commenting it out.
I would rather keep this as comment for this CL since NF1 is not really for I2S2 SCLK. If this needs to be removed, all these I2S2 related needs to be re-visited and make changes. A separate CL is needed for this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63945
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba5d83d133b6ae8cd389ddd971db308170094300
Gerrit-Change-Number: 63945
Gerrit-PatchSet: 6
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-CC: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 19:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-MessageType: comment