Change in coreboot[master]: superio/ite/it8772f/acpi: Convert superio.asl to ASL 2.0 syntax
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45989 )
Change subject: superio/ite/it8772f/acpi: Convert superio.asl to ASL 2.0 syntax ......................................................................
superio/ite/it8772f/acpi: Convert superio.asl to ASL 2.0 syntax
Change-Id: Ia7072112a1add1de9c3fb348bc70dbd404337819 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/fintek/f81803a/acpi/superio.asl 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/45989/1
diff --git a/src/superio/fintek/f81803a/acpi/superio.asl b/src/superio/fintek/f81803a/acpi/superio.asl index 302f2f4..4e2c525 100644 --- a/src/superio/fintek/f81803a/acpi/superio.asl +++ b/src/superio/fintek/f81803a/acpi/superio.asl @@ -152,7 +152,7 @@ ENTER_CONFIG_MODE (SUPERIO_UART_LDN) PNP_WRITE_IO(PNP_IO0, Arg0, IO0) PNP_WRITE_IRQ(PNP_IRQ0, Arg0, IR0) - Store (One, PNP_DEVICE_ACTIVE) + PNP_DEVICE_ACTIVE = 1 EXIT_CONFIG_MODE () } } @@ -221,7 +221,7 @@ ENTER_CONFIG_MODE (SUPERIO_UART_LDN) PNP_WRITE_IO(PNP_IO0, Arg0, IO0) PNP_WRITE_IRQ(PNP_IRQ0, Arg0, IR0) - Store (One, PNP_DEVICE_ACTIVE) + PNP_DEVICE_ACTIVE = 1 EXIT_CONFIG_MODE () } } @@ -244,7 +244,7 @@ { /* DBG0("SIO CPSI") */ ENTER_CONFIG_MODE(SUPERIO_PME_LDN) - Store(1, PSIN) + PSIN = 1 EXIT_CONFIG_MODE() } #endif
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45989 )
Change subject: superio/ite/it8772f/acpi: Convert superio.asl to ASL 2.0 syntax ......................................................................
Patch Set 1: Code-Review-1
Commit message does not match changes
Hello build bot (Jenkins), Angel Pons, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45989
to look at the new patch set (#2).
Change subject: superio/fintek/f81803a/acpi: Convert superio.asl to ASL 2.0 syntax ......................................................................
superio/fintek/f81803a/acpi: Convert superio.asl to ASL 2.0 syntax
Change-Id: Ia7072112a1add1de9c3fb348bc70dbd404337819 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/fintek/f81803a/acpi/superio.asl 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/45989/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45989 )
Change subject: superio/fintek/f81803a/acpi: Convert superio.asl to ASL 2.0 syntax ......................................................................
Patch Set 2:
Patch Set 1: Code-Review-1
Commit message does not match changes
Done. Thx
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45989 )
Change subject: superio/fintek/f81803a/acpi: Convert superio.asl to ASL 2.0 syntax ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45989 )
Change subject: superio/fintek/f81803a/acpi: Convert superio.asl to ASL 2.0 syntax ......................................................................
superio/fintek/f81803a/acpi: Convert superio.asl to ASL 2.0 syntax
Change-Id: Ia7072112a1add1de9c3fb348bc70dbd404337819 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45989 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/superio/fintek/f81803a/acpi/superio.asl 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/superio/fintek/f81803a/acpi/superio.asl b/src/superio/fintek/f81803a/acpi/superio.asl index 302f2f4..4e2c525 100644 --- a/src/superio/fintek/f81803a/acpi/superio.asl +++ b/src/superio/fintek/f81803a/acpi/superio.asl @@ -152,7 +152,7 @@ ENTER_CONFIG_MODE (SUPERIO_UART_LDN) PNP_WRITE_IO(PNP_IO0, Arg0, IO0) PNP_WRITE_IRQ(PNP_IRQ0, Arg0, IR0) - Store (One, PNP_DEVICE_ACTIVE) + PNP_DEVICE_ACTIVE = 1 EXIT_CONFIG_MODE () } } @@ -221,7 +221,7 @@ ENTER_CONFIG_MODE (SUPERIO_UART_LDN) PNP_WRITE_IO(PNP_IO0, Arg0, IO0) PNP_WRITE_IRQ(PNP_IRQ0, Arg0, IR0) - Store (One, PNP_DEVICE_ACTIVE) + PNP_DEVICE_ACTIVE = 1 EXIT_CONFIG_MODE () } } @@ -244,7 +244,7 @@ { /* DBG0("SIO CPSI") */ ENTER_CONFIG_MODE(SUPERIO_PME_LDN) - Store(1, PSIN) + PSIN = 1 EXIT_CONFIG_MODE() } #endif
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)