Attention is currently required from: Nico Huber. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56210 )
Change subject: console: Handle verstage as "first non-bootblock stage" ......................................................................
Patch Set 1:
(1 comment)
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/56210/comment/9fff15d7_f2ba5b2b PS1, Line 15: #endif I believe the NO_BOOTBLOCK_CONSOLE part here already made no sense to begin with, and this would be a good time to correct it. The reason we want to skip stuff in the "FIRST_CONSOLE" is because we're not sure if everything required will be initialized yet so early in the very first stage. But those dependencies aren't really console related, so when there is no bootblock console it doesn't make sense to transfer the same concerns to the next stage -- e.g. even when NO_BOOTBLOCK_CONSOLE is enabled, the bootblock will still set up CBFS (and whatever it may do for the option stuff), and we can still rely on that having been done in the next stage. (I hope Nico can chime in if he had something in mind with that code that I'm missing here.)
On the other hand, you do need to take the VBOOT_BEFORE_BOOTBLOCK case into account, where verstage is actually the first stage and then the bootblock comes after that (I know, it's a mess... I asked them not to do it that way, but here we are :/ ). We already have ENV_INITIAL_STAGE that is used by CBFS and FMAP code to figure this out, I think that would be idea to be used here as well.
-
Julius Werner (Code Review)