[XL] Change in coreboot[master]: mb/lenovo: Add new port for Lenovo L420 laptop

[Martin L Roth (Code Review)]

Attention is currently required from: Alexander Couzens, Felix Singer, Nicolas Provost.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75992?usp=email )

Change subject: mb/lenovo: Add new port for Lenovo L420 laptop
......................................................................

Patch Set 9: Code-Review+1

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/75992/comment/2e5e6139_7ee1fbc8 :
PS9, Line 8: 
Could you add a list of what's tested and anything that isn't currently working?

See https://review.coreboot.org/c/coreboot/+/74906 for an example of a commit message for a new board.

You could pretty much just copy the table out of your status.txt file into the commit message.

Patchset:

PS9: 
Hi Nicolas, Thanks for the port.  Everything looks pretty good here, and I think we can get it merged very shortly. I made a few comments, but mostly they don't need to be done in this commit. If we could at least get the commit message updated, the rest could really wait for later.

File src/mainboard/lenovo/l420/Kconfig:

https://review.coreboot.org/c/coreboot/+/75992/comment/8cb2911a_0352d5ff :
PS9, Line 3: config BOARD_SPECIFIC_OPTIONS
           : 	def_bool y
If you wouldn't mind, we're trying to get rid of all the "BOARD_SPECIFIC_OPTIONS" entries right now.

The better way to do this is:

```
config BOARD_LENOVO_L20
        select XXX
        select YYY
        select ZZZ

if BOARD_LENOVO_L20
...
```

File src/mainboard/lenovo/l420/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/75992/comment/4689e7f5_1f8ba8e8 :
PS9, Line 38: #include <src/northbridge/intel/sandybridge/chipset.cb>
This doesn't work - you can't include things into the devicetree.  The chipset.cb file will be automatically picked up by sconfig.

File src/mainboard/lenovo/l420/status.txt:

https://review.coreboot.org/c/coreboot/+/75992/comment/f61cf9df_2f94ab03 :
PS9, Line 1: L420 hardware status
Instead of putting this here, Maybe consider putting it in the Documentation/mainboard/lenovo directory.  It would obviously need to be converted to markdown, but that's not too difficult.