Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60694 )
Change subject: mb/google/jecht/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax ......................................................................
mb/google/jecht/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax
Replace `LGreaterEqual(a, b)` with `a >= b`.
Change-Id: I56e8fdb2503a84ded2bcf183402602579c3f2997 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl 4 files changed, 11 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/60694/1
diff --git a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl index e608ae4..84aea6f 100644 --- a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl @@ -77,7 +77,7 @@ Local1 = 255 - Local0
// Handle values greater than Tj_max - If (LGreaterEqual (Local1, \TMAX)) { + If (Local1 >= \TMAX) { Return (CTOK (\TMAX)) }
@@ -94,7 +94,7 @@ // Critical temperature in deci-kelvin Store (CTOK (\TMAX), Local1)
- If (LGreaterEqual (Local0, Local1)) { + If (Local0 >= Local1) { Printf ("CRITICAL TEMPERATURE: %o", Local0)
// Wait 1 second for SuperIO to re-poll diff --git a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl index e608ae4..84aea6f 100644 --- a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl @@ -77,7 +77,7 @@ Local1 = 255 - Local0
// Handle values greater than Tj_max - If (LGreaterEqual (Local1, \TMAX)) { + If (Local1 >= \TMAX) { Return (CTOK (\TMAX)) }
@@ -94,7 +94,7 @@ // Critical temperature in deci-kelvin Store (CTOK (\TMAX), Local1)
- If (LGreaterEqual (Local0, Local1)) { + If (Local0 >= Local1) { Printf ("CRITICAL TEMPERATURE: %o", Local0)
// Wait 1 second for SuperIO to re-poll diff --git a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl index e608ae4..84aea6f 100644 --- a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl @@ -77,7 +77,7 @@ Local1 = 255 - Local0
// Handle values greater than Tj_max - If (LGreaterEqual (Local1, \TMAX)) { + If (Local1 >= \TMAX) { Return (CTOK (\TMAX)) }
@@ -94,7 +94,7 @@ // Critical temperature in deci-kelvin Store (CTOK (\TMAX), Local1)
- If (LGreaterEqual (Local0, Local1)) { + If (Local0 >= Local1) { Printf ("CRITICAL TEMPERATURE: %o", Local0)
// Wait 1 second for SuperIO to re-poll diff --git a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl index d0522ca..3aa8fc3 100644 --- a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl @@ -117,13 +117,13 @@ }
If (LEqual (THTB, 2)) { - If (LGreaterEqual (Local0, THERMAL_POLICY_0_THRESHOLD_ON)) { + If (Local0 >= THERMAL_POLICY_0_THRESHOLD_ON) { TTB0 () - } ElseIf (LGreaterEqual (Local0, THERMAL_POLICY_1_THRESHOLD_ON)) { + } ElseIf (Local0 >= THERMAL_POLICY_1_THRESHOLD_ON) { TTB1 () } } ElseIf (LEqual (THTB, 1)) { - If (LGreaterEqual (Local0, THERMAL_POLICY_0_THRESHOLD_ON)) { + If (Local0 >= THERMAL_POLICY_0_THRESHOLD_ON) { TTB0 () } ElseIf (LLessEqual (Local0, THERMAL_POLICY_1_THRESHOLD_OFF)) { TTB2 () @@ -185,7 +185,7 @@ Local1 = 255 - Local0
// Handle values greater than Tj_max - If (LGreaterEqual (Local1, \TMAX)) { + If (Local1 >= \TMAX) { Return (CTOK (\TMAX)) }
@@ -202,7 +202,7 @@ // Critical temperature in deci-kelvin Store (CTOK (\TMAX), Local1)
- If (LGreaterEqual (Local0, Local1)) { + If (Local0 >= Local1) { Printf ("CRITICAL TEMPERATURE: %o", Local0)
// Wait 1 second for SuperIO to re-poll