Attention is currently required from: Sean Rhodes, Andy Pont.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52797 )
Change subject: ec: Add Star Labs ITE 8987E support
......................................................................
Patch Set 13: Code-Review+2
(2 comments)
File src/ec/starlabs/it8987/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/52797/comment/7b5316cd_218b24db
PS12, Line 373:
: // Method(_Q45) // SMM Mode - Not used in coreboot
: // {
: // SMB2 = 0xC1
: // }
Plan to use it in the future - hence it being left
Ack
File src/ec/starlabs/it8987/acpi/hid.asl:
PS12:
Reminder of the original source I guess. It's been happy for months now so it can go.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52797
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1967f7c4a7e3cab714f22844bf36749e0c9652b6
Gerrit-Change-Number: 52797
Gerrit-PatchSet: 13
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Comment-Date: Thu, 03 Jun 2021 15:10:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Rhodes
admin@starlabs.systems
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment