Attention is currently required from: Raul Rangel, Jon Murphy, Rob Barnes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62877 )
Change subject: mb/google/skyrim: Build APCB sources into amdfw when present
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
Are we going to need to update APCB tool so we can generate these?
We have asked AMD to refer to table of SPDs outside APCB. If that can be achieved, then I dont think we need to update APCB tool. Otherwise before fanning out to more variants, we need to update APCB tool to generate these. Thankfully we can leverage APCBv3 edit tool if needed.
File src/mainboard/google/skyrim/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/62877/comment/f9bc0686_21d367c0
PS2, Line 17: SBR_D5
Renamed it to be more consistent with previous generation of mainboards eg. guybrush.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62877
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71b30a5716f2e0d60d07a0ec29f98609c1f2a8b7
Gerrit-Change-Number: 62877
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Wed, 16 Mar 2022 22:22:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment