Kilian Neuner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant ......................................................................
Patch Set 12:
Patch Set 10:
Patch Set 10:
I finally got around to testing this patch. Seems to be working well for the most part. I just want to confirm that the brightness adjustment is still is not functional. Based on the comments, it is waiting on Nitrocaster to release the firmware to possibly find a software workaround for it? Is this correct?
No. brightness control is working, but there might be some artifacts from the ADC. When changing the brightness in a smooth way it shows you high brightness steps.
Hmm. When I use the function keys to change the brightness, the onscreen indicator shows that it is changing but the brightness stays the same. Same when I unplug my laptop, the power settings are supposed to dim the screen. I recompiled using v4.12 and patch v10, in a fresh directory, and flashed a second it again to ensure that didn't miss a step. Here is the deconfig I am using, https://github.com/Thrilleratplay/coreboot-builder-scripts/blob/x230_fhd/x23... and the nitrocast board is a v5 if that makes a difference.
Dimming works as expected for me in all aspects. Here is my defconfig for reference https://gist.github.com/9R/33fd59f5ebd68b53d82e05aecea16367
-
Kilian Neuner (Code Review)