Attention is currently required from: Hung-Te Lin, Paul Menzel, Angel Pons, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56792 )
Change subject: soc/mediatek/mt8195: Add driver to configure PCIe
......................................................................
Patch Set 19: -Code-Review
(1 comment)
File src/soc/mediatek/mt8195/pcie.c:
https://review.coreboot.org/c/coreboot/+/56792/comment/e2bb3175_2a61e1e9
PS19, Line 23: /* MMIO range (64MB): 0x20000000 ~ 0x24000000 */
: /* Some devices still need io ranges, reserve 16MB for compatibility */
: static struct mtk_pcie_mmio_res pcie_mmio_res_io = {
: .cpu_addr = 0x20000000,
: .pci_addr = 0x20000000,
: .size = 16 * MiB,
: .type = IORESOURCE_IO,
: };
:
: static struct mtk_pcie_mmio_res pcie_mmio_res_mem = {
: .cpu_addr = 0x21000000,
: .pci_addr = 0x21000000,
: .size = 48 * MiB,
: .type = IORESOURCE_MEM,
: };
These can be const, but CB:56791 needs to be updated to avoid compile-time errors about dropping "co […]
I agree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56792
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6799c53b03a33be91157ea088d829beb4272976
Gerrit-Change-Number: 56792
Gerrit-PatchSet: 19
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 07 Mar 2022 15:39:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment