Attention is currently required from: Justin Frodsham, Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50239 )
Change subject: soc/amd/cezanne: pass MMCONF base address to FSP via UPD
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Any reason not to just copy all the fields over to the header file? The struct will not match in FS […]
i try to only add the fields that we really need for now and where I'm reasonably sure that those won't change. since the code will only access the first field and leave the rest of the UPD unchanged, it's ok that only the beginning matches. sure it's not pretty, but just adding the struct from picasso seems less clean to me and will leave us with mismatching fsp and coreboot upd layouts as soon as we're making inompatible changes, which will happen due to moving the dxio descriptors from the fsp-s upds to the fsp-m upds
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50239
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81a812662f921d0bf8d436238d338b6a1fa6a9ee
Gerrit-Change-Number: 50239
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Attention: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 19:34:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-MessageType: comment