[XS] Change in coreboot[main]: soc/amd/glinda: Update I2C for glinda - coreboot-gerrit

16 Sep 2024


      Attention is currently required from: Maximilian Brune.
Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84382?usp=email )
Change subject: soc/amd/glinda: Update I2C for glinda
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/glinda/include/soc/smi.h:
https://review.coreboot.org/c/coreboot/+/84382/comment/52d50e5b_0df155cc?usp... :
PS1, Line 88: #define SMITYPE_USB_PD_I2C4		40
would be good to mark those as reserved to be consistent with the rest of the file
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84382?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I676e76aa2309d9ab82d63b48a2dec3c100241131
Gerrit-Change-Number: 84382
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Comment-Date: Mon, 16 Sep 2024 16:16:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No