Change in coreboot[master]: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver [WIP]
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39425 )
Change subject: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver [WIP] ......................................................................
Patch Set 9: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/39425/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39425/9//COMMIT_MSG@7 PS9, Line 7: [WIP] I would say it's pretty much done by now? I don't know if there's anything else missing before this may be submitted
https://review.coreboot.org/c/coreboot/+/39425/7/src/soc/intel/xeon_sp/gpio.... File src/soc/intel/xeon_sp/gpio.c:
https://review.coreboot.org/c/coreboot/+/39425/7/src/soc/intel/xeon_sp/gpio.... PS7, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Please use SPDX license headers
Done
https://review.coreboot.org/c/coreboot/+/39425/7/src/soc/intel/xeon_sp/gpio.... PS7, Line 32: skl
um, why SKL? maybe LBG?
Done
https://review.coreboot.org/c/coreboot/+/39425/7/src/soc/intel/xeon_sp/gpio.... PS7, Line 65: .port = PID_GPIOCOM0,
I know it's painful to do but... […]
My OCD says: Ah, gorgeous! Thank you! 😄
-
Angel Pons (Code Review)