Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32249
Change subject: nb/intel/sandybridge: Set uninitialized run length ......................................................................
nb/intel/sandybridge: Set uninitialized run length
If the entire array is zero, then the length of the longest zero run is the length of the array itself.
Found-by: Coverity Scan, CID 1229715 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: Id23292087b14182448d70117915fb044e9c579f7 --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/32249/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 55df03b..5ffb0d8 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -1142,6 +1142,7 @@ ret.middle = sz / 2; ret.start = 0; ret.end = sz; + ret.length = sz; ret.all = 1; return ret; }
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32249 )
Change subject: nb/intel/sandybridge: Set uninitialized run length ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32249/1/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/#/c/32249/1/src/northbridge/intel/sandybridge/ra... PS1, Line 1145: ret.length = sz; code indent should use tabs where possible
https://review.coreboot.org/#/c/32249/1/src/northbridge/intel/sandybridge/ra... PS1, Line 1145: ret.length = sz; please, no spaces at the start of a line
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32249
to look at the new patch set (#2).
Change subject: nb/intel/sandybridge: Set uninitialized run length ......................................................................
nb/intel/sandybridge: Set uninitialized run length
If the entire array is zero, then the length of the longest zero run is the length of the array itself.
Found-by: Coverity Scan, CID 1229715 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: Id23292087b14182448d70117915fb044e9c579f7 --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/32249/2
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32249 )
Change subject: nb/intel/sandybridge: Set uninitialized run length ......................................................................
Patch Set 2:
(2 comments)
Bah, gotta fix my vim config
https://review.coreboot.org/#/c/32249/1/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/#/c/32249/1/src/northbridge/intel/sandybridge/ra... PS1, Line 1145: ret.length = sz;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/32249/1/src/northbridge/intel/sandybridge/ra... PS1, Line 1145: ret.length = sz;
please, no spaces at the start of a line
Done
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32249 )
Change subject: nb/intel/sandybridge: Set uninitialized run length ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32249 )
Change subject: nb/intel/sandybridge: Set uninitialized run length ......................................................................
Patch Set 2: Code-Review+1
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32249 )
Change subject: nb/intel/sandybridge: Set uninitialized run length ......................................................................
nb/intel/sandybridge: Set uninitialized run length
If the entire array is zero, then the length of the longest zero run is the length of the array itself.
Found-by: Coverity Scan, CID 1229715 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: Id23292087b14182448d70117915fb044e9c579f7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32249 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Patrick Rudolph: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 55df03b..cbbd231 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -1142,6 +1142,7 @@ ret.middle = sz / 2; ret.start = 0; ret.end = sz; + ret.length = sz; ret.all = 1; return ret; }
-
build bot (Jenkins) (Code Review) -
Jacob Garber (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)