Julius Werner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34494 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
3rdparty/blobs: Update submodule
Uprev the 3rdparty/blobs submodule to the newest HEAD.
Change-Id: I8a4dfa7eaace1ea473f5970596c3201342e48927 Signed-off-by: Julius Werner jwerner@chromium.org --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/34494/1
diff --git a/3rdparty/blobs b/3rdparty/blobs index d7600dd..9da6d88 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit d7600dd8718a076f0f9a89e53968b484254624dc +Subproject commit 9da6d88a2b0f553b724e70d80a78d7e78f074f5b
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34494 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34494 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
Patch Set 1:
Maybe add to the commit message, why you need the new revision, that means what blobs.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34494 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
Patch Set 1: Code-Review+1
Hung-Te Lin has uploaded a new patch set (#2) to the change originally created by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/34494 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
3rdparty/blobs: Update submodule
Uprev the 3rdparty/blobs submodule to the newest HEAD, which contains the SSPM binary for MT8183 platforms ( https://review.coreboot.org/c/blobs/+/32698 ).
Change-Id: I8a4dfa7eaace1ea473f5970596c3201342e48927 Signed-off-by: Julius Werner jwerner@chromium.org --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/34494/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34494 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
Patch Set 2:
Maybe add to the commit message, why you need the new revision, that means what blobs.
Done
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34494 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
Patch Set 2:
Hmmm... again no Submit button for me here. But all comments are resolved, there's a Code-Review+2 and a Verified+1. Anyone have an idea what's missing?
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34494 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
Patch Set 2: Code-Review+2
"Approval from non-uploader required"
All Hung-te did was change the commit message, but I guess that counts. Let's see if I count as a non-uploader now...
Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34494 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
3rdparty/blobs: Update submodule
Uprev the 3rdparty/blobs submodule to the newest HEAD, which contains the SSPM binary for MT8183 platforms ( https://review.coreboot.org/c/blobs/+/32698 ).
Change-Id: I8a4dfa7eaace1ea473f5970596c3201342e48927 Signed-off-by: Julius Werner jwerner@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/34494 Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Julius Werner: Looks good to me, approved Hung-Te Lin: Looks good to me, approved
diff --git a/3rdparty/blobs b/3rdparty/blobs index d7600dd..9da6d88 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit d7600dd8718a076f0f9a89e53968b484254624dc +Subproject commit 9da6d88a2b0f553b724e70d80a78d7e78f074f5b
-
Hung-Te Lin (Code Review) -
Julius Werner (Code Review)
-
Paul Menzel (Code Review)