Attention is currently required from: Arthur Heymans, Srinivas Hegde.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79218?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: src/arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79218/comment/db4378ca_3b81c254 :
PS3, Line 7: src/
It’s normally left out of the prefix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79218?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia3cd51be6be252aa796191cf0d2cd91d393c8878
Gerrit-Change-Number: 79218
Gerrit-PatchSet: 3
Gerrit-Owner: Srinivas Hegde
srinivashegde@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Srinivas Hegde
srinivashegde@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 22 Nov 2023 19:11:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment