Attention is currently required from: Ana Carolina Cabral, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86300?usp=email )
Change subject: soc/amd/common/block/graphics: Support non VGA IGDs
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
maybe i've missed that, but this is likely missing a change to make the vfct generation part work fo […]
That's possible, this change is only to make sure vbt_get() returns a proper VBIOS to FSP. Haven't tested display lights up.
File src/soc/amd/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/86300/comment/8c5b4731_6e9547e6?usp... :
PS2, Line 157: PCI_RAM_IMAGE_START
Nvm, Felix already answer me that one.
No, `pci_rom_load` runs before the GOP driver runs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86300?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6ab28aab74f3169d45d7d852a37ddfcfc75b7c88
Gerrit-Change-Number: 86300
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 06 Feb 2025 15:34:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de