Change in ...coreboot[master]: lib/timestamp: Make timestamp_sync_cache_to_cbmem() in postcar

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32726

Change subject: lib/timestamp: Make timestamp_sync_cache_to_cbmem() in postcar
......................................................................

lib/timestamp: Make timestamp_sync_cache_to_cbmem() in postcar

This patch ensures to have correct timestamp value if plan
to skip ramstage using CONFIG_RAMPAYLOAD.

Change-Id: I3ba3a54c20dfcdaf5b87818cc5da9a812f5f2edf
Signed-off-by: Subrata Banik 
---
M src/lib/timestamp.c
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/32726/1

diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c
index cf882b8..74548ab 100644
--- a/src/lib/timestamp.c
+++ b/src/lib/timestamp.c
@@ -353,6 +353,9 @@
 }

ROMSTAGE_CBMEM_INIT_HOOK(timestamp_sync_cache_to_cbmem)
+#if CONFIG(RAMPAYLOAD)
+POSTCAR_CBMEM_INIT_HOOK(timestamp_sync_cache_to_cbmem)
+#endif
 RAMSTAGE_CBMEM_INIT_HOOK(timestamp_sync_cache_to_cbmem)

/* Provide default timestamp implementation using monotonic timer. */

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32726 )

Change subject: lib/timestamp: Make timestamp_sync_cache_to_cbmem() in postcar
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32726/1/src/lib/timestamp.c 
File src/lib/timestamp.c:

https://review.coreboot.org/#/c/32726/1/src/lib/timestamp.c@356 
PS1, Line 356: #if CONFIG(RAMPAYLOAD)
shouldn't that be done unconditionally?

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32726 )

Change subject: lib/timestamp: Make timestamp_sync_cache_to_cbmem() in postcar
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32726/1/src/lib/timestamp.c 
File src/lib/timestamp.c:

https://review.coreboot.org/#/c/32726/1/src/lib/timestamp.c@356 
PS1, Line 356: #if CONFIG(RAMPAYLOAD)
> shouldn't that be done unconditionally?

yes, i can do that, if you can approve :)
i was thinking this should have been unconditional

[Subrata Banik (Code Review)]

Hello Aaron Durbin, ron minnich, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32726

to look at the new patch set (#2).

Change subject: lib/timestamp: Make timestamp_sync_cache_to_cbmem() in postcar
......................................................................

lib/timestamp: Make timestamp_sync_cache_to_cbmem() in postcar

This patch ensures to have correct timestamp value in postcar.

Change-Id: I3ba3a54c20dfcdaf5b87818cc5da9a812f5f2edf
Signed-off-by: Subrata Banik 
---
M src/lib/timestamp.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/32726/2

[ron minnich (Code Review)]

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32726 )

Change subject: lib/timestamp: Make timestamp_sync_cache_to_cbmem() in postcar
......................................................................

Patch Set 2:

(1 comment)

I think patrick is right too.

https://review.coreboot.org/#/c/32726/1/src/lib/timestamp.c 
File src/lib/timestamp.c:

https://review.coreboot.org/#/c/32726/1/src/lib/timestamp.c@356 
PS1, Line 356: #if CONFIG(RAMPAYLOAD)
> yes, i can do that, if you can approve :) […]

I agree too.

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32726 )

Change subject: lib/timestamp: Make timestamp_sync_cache_to_cbmem() in postcar
......................................................................

Patch Set 2: Code-Review+2

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32726 )

Change subject: lib/timestamp: Make timestamp_sync_cache_to_cbmem() in postcar
......................................................................

lib/timestamp: Make timestamp_sync_cache_to_cbmem() in postcar

This patch ensures to have correct timestamp value in postcar.

Change-Id: I3ba3a54c20dfcdaf5b87818cc5da9a812f5f2edf
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32726
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Rudolph 
---
M src/lib/timestamp.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved

diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c
index b6330fa..431bce2 100644
--- a/src/lib/timestamp.c
+++ b/src/lib/timestamp.c
@@ -350,6 +350,7 @@
 }

ROMSTAGE_CBMEM_INIT_HOOK(timestamp_sync_cache_to_cbmem)
+POSTCAR_CBMEM_INIT_HOOK(timestamp_sync_cache_to_cbmem)
 RAMSTAGE_CBMEM_INIT_HOOK(timestamp_sync_cache_to_cbmem)

/* Provide default timestamp implementation using monotonic timer. */