Julius Werner has posted comments on this change. ( https://review.coreboot.org/19502 )
Change subject: lib/edid.c: Return value differentiates absent and non-conformant ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/19502/5/src/drivers/parade/ps8640/ps8640.c File src/drivers/parade/ps8640/ps8640.c:
Line 50: if (decode_edid(edid, edid_size, out) != EDID_CONFORMANT) { Why do all these have to be changed? Why not just carefully assign the new return values so that EDID_CONFORMANT is 0, EDID_NON_CONFORMANT is -1 and EDID_ABSENT is -2 or something (so that you can still use a blanket (decode_edid() < 0) to check for conformance).