Wonkyu Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30861
Change subject: Update mainboard UART Kconfig for whlrvp ......................................................................
Update mainboard UART Kconfig for whlrvp
Change-Id: Ic56c019a12b467e5bede5648098d3fb82b56ba7e Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com --- M src/mainboard/intel/coffeelake_rvp/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/30861/1
diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig b/src/mainboard/intel/coffeelake_rvp/Kconfig index 9474c51..1634e71 100644 --- a/src/mainboard/intel/coffeelake_rvp/Kconfig +++ b/src/mainboard/intel/coffeelake_rvp/Kconfig @@ -7,6 +7,7 @@ select GENERIC_SPD_BIN select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select INTEL_LPSS_UART_FOR_CONSOLE if BOARD_INTEL_WHISKEYLAKE_RVP select MAINBOARD_HAS_CHROMEOS select GENERIC_SPD_BIN select DRIVERS_I2C_HID @@ -48,6 +49,10 @@ default 12 if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 default 8
+config UART_FOR_CONSOLE + int + default 2 + config DEVICETREE string default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
Wonkyu Kim has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/30861 )
Change subject: soc/mainboard: Update mainboard UART Kconfig ......................................................................
soc/mainboard: Update mainboard UART Kconfig
Update mainboard UART Kconfig for whlrvp
Change-Id: Ic56c019a12b467e5bede5648098d3fb82b56ba7e Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com --- M src/mainboard/intel/coffeelake_rvp/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/30861/2
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30861 )
Change subject: soc/mainboard: Update mainboard UART Kconfig ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30861/2/src/mainboard/intel/coffeelake_rvp/K... File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/#/c/30861/2/src/mainboard/intel/coffeelake_rvp/K... PS2, Line 54: default 2 Will that need to be 0 for other variant?
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30861 )
Change subject: soc/mainboard: Update mainboard UART Kconfig ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/30861/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30861/2//COMMIT_MSG@7 PS2, Line 7: soc/mainboard It have only one board, that's better to be mb/intel/coffeelake_rvp
https://review.coreboot.org/#/c/30861/2//COMMIT_MSG@9 PS2, Line 9: Update mainboard UART Kconfig for whlrvp Add . at the end of sentence. Also better including a section about test.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30861
to look at the new patch set (#3).
Change subject: mb/intel/coffeelake_rvp: Update mainboard UART Kconfig ......................................................................
mb/intel/coffeelake_rvp: Update mainboard UART Kconfig
Update mainboard UART Kconfig for Whiskylake RVP.
TEST=Build and test on Whiskylake RVP. By default we can still get console from cbmem, and enable CONSOLE_SERIAL can get logs from UART port2. Select other Coffeelake RVPs and check CONSOLE_SERIAL is enabled.
Change-Id: Ic56c019a12b467e5bede5648098d3fb82b56ba7e Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com --- M src/mainboard/intel/coffeelake_rvp/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/30861/3
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30861 )
Change subject: mb/intel/coffeelake_rvp: Update mainboard UART Kconfig ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/30861/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30861/2//COMMIT_MSG@7 PS2, Line 7: soc/mainboard
It have only one board, that's better to be mb/intel/coffeelake_rvp
Done
https://review.coreboot.org/#/c/30861/2//COMMIT_MSG@9 PS2, Line 9: Update mainboard UART Kconfig for whlrvp
Add . at the end of sentence. Also better including a section about test.
Done
https://review.coreboot.org/#/c/30861/2/src/mainboard/intel/coffeelake_rvp/K... File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/#/c/30861/2/src/mainboard/intel/coffeelake_rvp/K... PS2, Line 54: default 2
Will that need to be 0 for other variant?
Done
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30861 )
Change subject: mb/intel/coffeelake_rvp: Update mainboard UART Kconfig ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30861 )
Change subject: mb/intel/coffeelake_rvp: Update mainboard UART Kconfig ......................................................................
mb/intel/coffeelake_rvp: Update mainboard UART Kconfig
Update mainboard UART Kconfig for Whiskylake RVP.
TEST=Build and test on Whiskylake RVP. By default we can still get console from cbmem, and enable CONSOLE_SERIAL can get logs from UART port2. Select other Coffeelake RVPs and check CONSOLE_SERIAL is enabled.
Change-Id: Ic56c019a12b467e5bede5648098d3fb82b56ba7e Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-on: https://review.coreboot.org/c/30861 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lijian Zhao lijian.zhao@intel.com --- M src/mainboard/intel/coffeelake_rvp/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved
diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig b/src/mainboard/intel/coffeelake_rvp/Kconfig index 9474c51..95eeeff 100644 --- a/src/mainboard/intel/coffeelake_rvp/Kconfig +++ b/src/mainboard/intel/coffeelake_rvp/Kconfig @@ -7,6 +7,7 @@ select GENERIC_SPD_BIN select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select INTEL_LPSS_UART_FOR_CONSOLE if BOARD_INTEL_WHISKEYLAKE_RVP select MAINBOARD_HAS_CHROMEOS select GENERIC_SPD_BIN select DRIVERS_I2C_HID @@ -48,6 +49,11 @@ default 12 if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 default 8
+config UART_FOR_CONSOLE + int + default 2 if BOARD_INTEL_WHISKEYLAKE_RVP + default 0 + config DEVICETREE string default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
-
Lijian Zhao (Code Review) -
Patrick Georgi (Code Review)
-
Wonkyu Kim (Code Review)