Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29638 )
Change subject: SMBIOS: Remove duplicated smbios_memory_type enum ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Some people would say this should be 2 separate commits, or have a title that clearly indicate both things. Why not "SMBIOS: Update to version 3.2.0"? Then you can add any other modification related to this version on the same commit.
Over all looks good, but unless you break it in 2 commits or change the title to something that involves both actions (and possibly more), someone else will have to approve.
https://review.coreboot.org/#/c/29638/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29638/2//COMMIT_MSG@9 PS2, Line 9: memory_speed
"memory speed" is the name done by SMBIOS version 3.2.0 […]
Ok
https://review.coreboot.org/#/c/29638/2/src/include/smbios.h File src/include/smbios.h:
https://review.coreboot.org/#/c/29638/2/src/include/smbios.h@a122 PS2, Line 122: : : : : :
Please see line #140 (new file)
OK, I see.