[S] Change in coreboot[master]: drivers/net/phy/m88e1512: Add a way to set output impedance manually - coreboot-gerrit

1 Mar 2023


      Attention is currently required from: Mario Scheithauer.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73018 )
Change subject: drivers/net/phy/m88e1512: Add a way to set output impedance manually
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/drivers/net/phy/m88e1512/m88e1512.c:
https://review.coreboot.org/c/coreboot/+/73018/comment/dfdb3218_eb249612 
PS1, Line 84:  Force with a second register write the new values
What about 'Activate the new setting.'?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/73018
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87fa03aa49514cdc33d2911d7f23386c8f69d95b
Gerrit-Change-Number: 73018
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Comment-Date: Wed, 01 Mar 2023 12:22:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment