Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49092 )
Change subject: cpu/intel/model_206ax: Always return a package from _CST ......................................................................
cpu/intel/model_206ax: Always return a package from _CST
The _CST method is supposed to return a package. If a mainboard used zero for all ACPI C-states, the generated _CST would return nothing, which is invalid. Instead, return a package with no C-state entries.
This change is a no-op, since all mainboards have at least one valid ACPI C-state. This is what `acpigen_write_CST_package()` does, too.
Change-Id: I1f531e168683ed108a8d6d03dee6f5415fd15587 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/model_206ax/acpi.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/49092/1
diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c index b53e505..beb2fbc 100644 --- a/src/cpu/intel/model_206ax/acpi.c +++ b/src/cpu/intel/model_206ax/acpi.c @@ -31,8 +31,6 @@ ++cstate_count; if (c3 > 0) ++cstate_count; - if (!cstate_count) - return;
acpigen_write_package(cstate_count + 1); acpigen_write_byte(cstate_count);
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49092 )
Change subject: cpu/intel/model_206ax: Always return a package from _CST ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49092 )
Change subject: cpu/intel/model_206ax: Always return a package from _CST ......................................................................
cpu/intel/model_206ax: Always return a package from _CST
The _CST method is supposed to return a package. If a mainboard used zero for all ACPI C-states, the generated _CST would return nothing, which is invalid. Instead, return a package with no C-state entries.
This change is a no-op, since all mainboards have at least one valid ACPI C-state. This is what `acpigen_write_CST_package()` does, too.
Change-Id: I1f531e168683ed108a8d6d03dee6f5415fd15587 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49092 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/intel/model_206ax/acpi.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c index b53e505..beb2fbc 100644 --- a/src/cpu/intel/model_206ax/acpi.c +++ b/src/cpu/intel/model_206ax/acpi.c @@ -31,8 +31,6 @@ ++cstate_count; if (c3 > 0) ++cstate_count; - if (!cstate_count) - return;
acpigen_write_package(cstate_count + 1); acpigen_write_byte(cstate_count);
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)