Change in coreboot[master]: Signed-off-by: Sean Rhodes <[e-mail]> Change-Id: I8023c2...

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58346 )

Change subject: Signed-off-by: Sean Rhodes  Change-Id: I8023c26de23c874c84106fda96e64dcfa0c5ba32
......................................................................

Patch Set 1:

(12 comments)

File src/ec/starlabs/merlin/acpi/ec.asl:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/67e79cfd_6993507e 
PS1, Line 101: 			Return (Local1)						// Return incase Arg0 doesnt exist
'incase' may be misspelled - perhaps 'in case'?

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/54270910_68ebdb09 
PS1, Line 101: 			Return (Local1)						// Return incase Arg0 doesnt exist
'doesnt' may be misspelled - perhaps 'doesn't'?

File src/ec/starlabs/merlin/ec.c:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/ea865237_ea0c1a26 
PS1, Line 70: 	switch (get_uint_option("kbl_timeout", 0)) {
switch and case should be at the same indent

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/7abcee6f_1485f339 
PS1, Line 97: 	switch (get_uint_option("fn_ctrl_swap", 0)) {
switch and case should be at the same indent

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/bd29921e_1792e33e 
PS1, Line 115: 	switch (get_uint_option("max_charge", 0)) {
switch and case should be at the same indent

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/5c1ed9e4_ae8bc150 
PS1, Line 123: 		 	ec_write(ECRAM_MAX_CHARGE, CHARGE_100);
code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/5fd15e81_86808933 
PS1, Line 123: 		 	ec_write(ECRAM_MAX_CHARGE, CHARGE_100);
please, no space before tabs

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/1091b63e_ac5b11b5 
PS1, Line 136: 	switch (get_uint_option("fan_mode", 0)) {
switch and case should be at the same indent

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/37820437_63362941 
PS1, Line 157: 	switch (get_uint_option("fn_lock_state", 0)) {
switch and case should be at the same indent

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/27c28e9b_111fe16e 
PS1, Line 175: 	switch (get_uint_option("trackpad_state", 0)) {
switch and case should be at the same indent

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/e5d831ca_441c232d 
PS1, Line 193: 	switch (get_uint_option("kbl_brightness", 0)) {
switch and case should be at the same indent

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/be153d40_31fc9183 
PS1, Line 220: 	switch (get_uint_option("kbl_state", 0)) {
switch and case should be at the same indent