Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Paul Menzel, Simon Glass.
Simon Glass has posted comments on this change by Simon Glass. ( https://review.coreboot.org/c/coreboot/+/77712?usp=email )
Change subject: Introduce a coreboot Control Block (CCB) ......................................................................
Patch Set 10:
(7 comments)
Patchset:
PS10:
-- here is where CBFS turns up I suppose: […]
The goal of CCB (for console) is to allow all output to be produced, or none. It isn't trying to suppress just 'some' output, or allow some output, but not other output.
I understand about keeping things simple, but we can't really use this feature if it doesn't work for all output. It would just be a half-baked solution and people would not use it.
Commit Message:
https://review.coreboot.org/c/coreboot/+/77712/comment/1fa39094_6cf68bf8?usp... : PS2, Line 7: Post-build control of serial
This change adds the CCB subsystem, *and* it also uses the CCB subsystem to allow post-build control […]
I split these into two commits
File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/77712/comment/6df06943_8b057bba?usp... : PS10, Line 45: CCB(., 0x10)
This file only affects x86 devices (excluding AMD). […]
Do timestamps suffer from the same issue? What is the solution to resolve this?
File src/console/Kconfig:
https://review.coreboot.org/c/coreboot/+/77712/comment/0be5523f_046abcd0?usp... : PS10, Line 433: default y
Any feature for runtime control of console behavior should probably be based on loglevel as it was s […]
I have a plan to expand this to allow loglevel to be changed at runtime. But this CL is the smallest useful implementation, so I am starting here.
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/77712/comment/5b1179db_55af4420?usp... : PS5, Line 45: return CONSOLE_LOG_FAST;
Could we leave that until later? Yes, I believe we could add something to control that too
Acknowledged
File src/lib/ccb.c:
https://review.coreboot.org/c/coreboot/+/77712/comment/8037e9ed_fc923005?usp... : PS3, Line 8: struct ccb ccb_static __attribute__((section(".init"))) = {
Not that I can see. […]
Acknowledged
File src/lib/hardwaremain.c:
https://review.coreboot.org/c/coreboot/+/77712/comment/4a5ba60a_521e98a9?usp... : PS10, Line 449: cbmem_initialize();
Moving cbmem_initialize() above console_init() makes it impossible to debug CBMEM initialization han […]
But in that case you wouldn't set the console to silent, would you?
-
Simon Glass (Code Review)