Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, SH Kim.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81105?usp=email )
Change subject: mb/google/brya/var/xol: Disable unused controllers
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81105/comment/a7755940_df3cc335 :
PS1, Line 14: - PCIE RP8
: - PCIE RP9
Yeah, I understand your remark, it must be a more powerful way to disable PCIe RP.
RP8 is under PCIe 5-8 group and PR9 is under PCIe 9-12. Currently PCIe 5-8 is set as 4x1 and PCIe 9-12 is set as 1x4. It's following baseboard config.
I'd like to keep current softstrap for future. I believe the runtime job to disable PCIe RPs in coreboot/FSP is not a big deal. Now we are under proto stage, there is a posibility to support another device through PCIe port in future. Then we only need coreboot change for it.
sure, let's keep this for future if possible.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81105?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1be7caf8234c32406aa2cff8fc7fe9fa39b16d89
Gerrit-Change-Number: 81105
Gerrit-PatchSet: 1
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 08 Mar 2024 06:55:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-MessageType: comment