Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48083 )
Change subject: mb/supermicro/x11-lga1151-series: set mainboard_ops.init directly ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48083/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48083/5//COMMIT_MSG@9 PS5, Line 9: Set mainboard_ops.init directly instead of using the indirection via a : mainboard_enable function.
chip.init is run significantly earlier than dev.init, before resources are allocated. […]
huh? this does not change any behaviour. mainboard_ops.init was set by mainboard_enable, which runs before .init . now it's set in the struct at compile time, like it's done for any other chip/driver (except a few, where it's done wrong like here), so where's the problem?